#driverkit

Ryan around the Web

• Appreciate the PR. :)

  It's been a few years since I touched this particular functionality, but (IIRC) I think I opted not to expose these because modern macOS modal views should really be using the sheets API. The filesystem module uses this API as it just works around the thorny issue of handling file selection in a synchronous manner - this is typically an operation where "stop the world" isn't the end of the world.

  That said, I think the PR is probably still useful - but I'd maybe add some additional documentation to the function docs that just notes the above. I also think you're right and that ModalResponse should probably just move out if these methods are public. on Add wrappers for starting and stopping modal windows 19 hours ago

• Merged - thanks! on Added helper functions 2 weeks ago
• Pushed 1 commit to @ryanmcgrath/cacao 2 weeks ago
• Closed a pull request in @ryanmcgrath/cacao:

  Added helper functions 2 weeks ago

• These look good, but if you could just add a /// one liner above each then I'd be down to merge.

  Thanks! on Added helper functions 2 weeks ago

• Ehhhh, I see your point.

  If nothing else, might be useful to add a note to the struct docstring - for someone like me who's only ever looked at the spec once in an eternity, it might be a helpful thing to call out so people don't further author non-compliant feeds. on Should Content use an enum to differentiate between src and value? 3 weeks ago

• This is likely the same (ish) issue as #122 - probably a thing that was being properly retained before is not being retained now.

  I have to find time to dig in and poke at this stuff, but I've been fairly busy as of late - but the last non-beta version should theoretically be fine if you're finding this a blocker. Appreciate the heads up otherwise! on todos_list Example Program Crashes in Release Mode a month ago

• …what thing are you packaging that depends on this?

  I guess it could be removed if it’s a formality - if it’s there it’s probably a decade or so old and I’d have no context beyond that lol

  On Sun, Aug 11, 2024 at 22:27, Paul Pfeister @.***(mailto:On Sun, Aug 11, 2024 at 22:27, Paul Pfeister < wrote:

  Hey @.(https://github.com/ryanmcgrath)> on Remove nose-cov dependency?

  2 months ago

• which unless I am mistaken

  I do not believe you are. :)

  A PR is welcome, otherwise I'll get to it in the next batch of fixes once I find the time. Thanks for the callout! on AttributedString::set_text_color uses range end as a length 2 months ago

• Huh, it's likely a simple-ish fix of just changing the crate name to use underscores for consistency. It's not like it gets uploaded or distributed outside the project.

  I'll see about poking at this over the weekend since the way Windows finds the lib is a bit custom.

  (I don't suppose there's a way to force the Cargo 1.78 behavior anywhere, is there?) on Build breaks after Cargo 1.79 2 months ago

• I don't know of any particular way to do that and I'm not really inclined to support it, since it's an ultra-niche use case.

  Someone is free to PR it, but with DriverKit being the way it is I feel like it'd be tricky to develop outside of this org - but perhaps with a properly disabled SIP + systemextensionctl setup it's possible.

  You might be able to get away with using just gcusbadapter.kext from the hjelmn project (with SIP kext checks disabled only, don't disable all of SIP necessarily), since GCAdapterDriver handles the part that gcusbadapter_raw.kext does. kexts are not guaranteed to work forever though, so... YMMV.

  on Expose GC Controllers to system as Gamepads? 2 months ago

• Well then.

  Thanks for catching that, heh. Merged! on fix: typo in window’s set_subtitle fn 2 months ago